From gerrit@openafs.org Thu May 2 17:15:47 2024 From: gerrit@openafs.org (Gerrit Code Review) Date: Thu, 2 May 2024 12:15:47 -0400 Subject: OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_11-10-gbe8001f Message-ID: <202405021615.442GFlGd123977@openafs.MIT.EDU> The following commit has been merged in the openafs-stable-1_8_x branch: commit be8001f1d64a2d9da4fdaeff59fdc40e205d4526 Author: Cheyenne Wills Date: Thu Feb 8 12:22:13 2024 -0700 afs: Remove SRXAFSCB_FetchData/StoreData Commit 'client-64bit-file-size-support-20011031' (971b18bc42) introduced the RPC functions SRXAFSCB_FetchData() and SRXAFSCB_StoreData with RPC numbers of 65536 and 65537 respectively. Commit 'more-64bit-file-size-support-20011031' (c5b1a3775f) removed the references from afscbint.xg, but did not remove the actual code. The 65536 RPC number was reassigned to SRXAFSCB_GetCE64, and the commit: 'This is mostly a rewrite of src/afs/afs_cell.c, and associated changes' (629d08065) assigned the 65537 RPC to SRXAFSCB_GetCellByNum. Remove the 2 functions since there are no references other than the prototype in afs_prototypes.h. This function is flagged due to a missing prototype when building against a Linux 6.8 kernel (which sets the -Wmissing-declarations and -Wmissing-prototypes compiler flags as default). Linux 6.8 commit: 'Makefile.extrawarn: turn on missing-prototypes globally' (0fcb70851f). Reviewed-on: https://gerrit.openafs.org/15639 Reviewed-by: Andrew Deason Tested-by: BuildBot Reviewed-by: Benjamin Kaduk (cherry picked from commit 379f7fc51d411990189ec28e48c91edc87d76120) Change-Id: I1a3539227d22e6df89d78245634dfeb14943035a Reviewed-on: https://gerrit.openafs.org/15688 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Michael Meffie Reviewed-by: Benjamin Kaduk src/afs/afs_callback.c | 65 ------------------------------------------------ src/afs/afs_prototypes.h | 7 ------ 2 files changed, 72 deletions(-) -- OpenAFS Master Repository From gerrit@openafs.org Thu May 2 17:24:50 2024 From: gerrit@openafs.org (Gerrit Code Review) Date: Thu, 2 May 2024 12:24:50 -0400 Subject: OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_11-12-g5d2c4a0 Message-ID: <202405021624.442GOoqU126354@openafs.MIT.EDU> The following commit has been merged in the openafs-stable-1_8_x branch: commit 5d2c4a0a8ada4a87d7f39dc21dbce14b3b2a978f Author: Cheyenne Wills Date: Fri Jan 12 15:52:57 2024 -0700 afs: Add declaration for RXAFS_ResidencyCmd() The function RXAFS_ResidencyCmd() is 'manually' defined within the afsint.xg, so a prototype for the function is not defined. This function is flagged due to a missing prototype when building against a Linux 6.8 kernel (which sets the -Wmissing-declarations and -Wmissing-prototypes compiler flags as default). Linux 6.8 commit: 'Makefile.extrawarn: turn on missing-prototypes globally' (0fcb70851f). When building against a kernel with CONFIG_WERROR=y, the build fails. Add a prototype for RXAFS_ResidencyCmd There are no functional changes with this commit The function RXAFS_ResidencyCmd() was introduced with commit: 'rename-residency-from-mrafs-to-osd-20090427' (8655541d1e) Reviewed-on: https://gerrit.openafs.org/15619 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Benjamin Kaduk (cherry picked from commit 1d6cfbc5f627abf3808aae97afb72662301483b5) Change-Id: I42d0868b83e119b0c3348a3af8aaf5961c040bb2 Reviewed-on: https://gerrit.openafs.org/15690 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Michael Meffie Reviewed-by: Benjamin Kaduk src/fsint/afsint.xg | 1 + 1 file changed, 1 insertion(+) -- OpenAFS Master Repository From gerrit@openafs.org Sun May 12 22:46:54 2024 From: gerrit@openafs.org (Gerrit Code Review) Date: Sun, 12 May 2024 17:46:54 -0400 Subject: OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_11-14-gb1c93f1 Message-ID: <202405122146.44CLksXY044549@openafs.MIT.EDU> The following commit has been merged in the openafs-stable-1_8_x branch: commit b1c93f13870e24795b857cb483320871703d00e8 Author: Cheyenne Wills Date: Wed Feb 7 15:25:10 2024 -0700 Linux 6.8: Add function prototypes for krb5 The external files for heimdal/krb5 do not provide function prototypes in a header file that is used when building files that we use from heimdal/krb5 (e.g. crypto.c). These functions are flagged due to missing prototypes when building against a Linux 6.8 kernel (which sets the -Wmissing-declarations and -Wmissing-prototypes compiler flags as default). Linux 6.8 commit: 'Makefile.extrawarn: turn on missing-prototypes globally' (0fcb70851f). When building against a kernel with CONFIG_WERROR=y, the build fails. We cannot modify the external source files, however there is the local OpenAFS include file, krb5_locl.h, that does contain OpenAFS specific changes. Add declarations to krb5_locl.h for the functions defined in the heimdal/krb5 source. There are no functional changes with this commit. Reviewed-on: https://gerrit.openafs.org/15621 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Benjamin Kaduk (cherry picked from commit 612927dd1dd44bbd08eda790de12b24213583156) Change-Id: Iaae28186a24c3c5ca4407de9563c8cfed9644921 Reviewed-on: https://gerrit.openafs.org/15692 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Michael Meffie Reviewed-by: Benjamin Kaduk src/crypto/rfc3961/krb5_locl.h | 132 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 132 insertions(+) -- OpenAFS Master Repository From gerrit@openafs.org Mon May 13 03:46:25 2024 From: gerrit@openafs.org (Gerrit Code Review) Date: Sun, 12 May 2024 22:46:25 -0400 Subject: OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_11-19-g53752b0 Message-ID: <202405130246.44D2kPIa004514@openafs.MIT.EDU> The following commit has been merged in the openafs-stable-1_8_x branch: commit 53752b01bc734f4bd5f5da24ac116c7fcb2ac07f Author: Cheyenne Wills Date: Mon Feb 12 09:43:29 2024 -0700 afs: Remove SRXAFSCB* protos from afs_prototypes.h The prototypes for the afscbint RPC functions (SRXAFSCB_*) implemented in afs_callback.c are defined in 2 locations, afs_protypes.h and afscbint.h (which is generated by rxgen). Remove the protoypes for the SRXAFSCB_* functions from afs_prototypes.h as they are redundant and are currently out of sync (the prototypes for SRXAFSCB_GetCellByNum() and SRXAFSCB_TellMeAboutYourself() are not present in afs_prototypes.h). Also remove a redundant prototype for afs_RXCallBackServer() which was prototyped both before and in the middle of the SRXAFSCB* prototypes. Since afs_callback.c only pulled in afs_prototypes.h and not afscbint.h, add an include for afscbint.h to ensure that the all the prototypes for the SRXAFSCB_* functions are present. The 2 functions listed above are flagged due to missing prototypes when building against a Linux 6.8 kernel (which sets the -Wmissing-declarations and -Wmissing-prototypes compiler flags as default). Linux 6.8 commit: 'Makefile.extrawarn: turn on missing-prototypes globally' (0fcb70851f). When building against a kernel with CONFIG_WERROR=y, the build fails. Reviewed-on: https://gerrit.openafs.org/15644 Reviewed-by: Mark Vitale Tested-by: Benjamin Kaduk Reviewed-by: Benjamin Kaduk (cherry picked from commit fae4003b403420d0b548920c7837a2d2b6e432ae) Change-Id: I7d435455fc60cc10200ee91d0d76534367ab5883 Reviewed-on: https://gerrit.openafs.org/15697 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Michael Meffie Reviewed-by: Benjamin Kaduk src/afs/afs_callback.c | 2 ++ src/afs/afs_prototypes.h | 37 ------------------------------------- 2 files changed, 2 insertions(+), 37 deletions(-) -- OpenAFS Master Repository From gerrit@openafs.org Mon May 13 03:52:10 2024 From: gerrit@openafs.org (Gerrit Code Review) Date: Sun, 12 May 2024 22:52:10 -0400 Subject: OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_11-21-g90b8dcf Message-ID: <202405130252.44D2qAWc005458@openafs.MIT.EDU> The following commit has been merged in the openafs-stable-1_8_x branch: commit 90b8dcff36e9b03ec01550ad1a070a0ab7db8c46 Author: Cheyenne Wills Date: Fri Feb 9 09:01:33 2024 -0700 afs: fix 'ops' variable may be used uninitialized When the function rxfs_storeInit() has the static attribute, gcc flags the variable 'ops' as possibly uninitialized. In function 'afs_CacheStoreDCaches', inlined from 'afs_CacheStoreVCache' at .../src/afs/afs_fetchstore.c:630:14: .../afs/afs_fetchstore.c:535:17: error: 'ops' may be used uninitialized [-Werror=maybe-uninitialized] 535 | code = (*ops->destroy)(&rock, code); | ~^~~~~~~~~~~~~~ ...src/afs/afs_fetchstore.c: In function 'afs_CacheStoreVCache': ...src/afs/afs_fetchstore.c:567:22: note: 'ops' was declared here 567 | struct storeOps *ops; | ^~~ cc1: all warnings being treated as errors This is a false positive report by the gcc compiler. The function rxfs_storeInit() returns a 0 only when it has successfully assigned a value to the ops variable, and afs_CacheStoreDcaches() is only called if the return value from rxfs_storeInit() is 0. The ops variable is only used within a block that is within a for loop, which could leave a stray value if the variable isn't initialized within that loop. Assigning a NULL to ops is sufficient to avoid the compiler error, and relocating the declaration of the ops variable into the block where it is actually used ensures that it's always initialized before its use within the loop. Clean up whitespace in the statement that follows the new location for the ops variable. Note, this commit is being added before a commit that adds the static attribute to the rxfs_storeInit() function which also "fixes" the compiler error (see: afs: Add static attribute to internal functions). Reviewed-on: https://gerrit.openafs.org/15630 Reviewed-by: Andrew Deason Tested-by: BuildBot Reviewed-by: Mark Vitale Reviewed-by: Benjamin Kaduk (cherry picked from commit 36e4c02ff27b9d66755b9544778896b9b1e5c391) Change-Id: I9d8a07e576c6bf889f8f182c6fc0d34dc997c004 Reviewed-on: https://gerrit.openafs.org/15699 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Michael Meffie Reviewed-by: Benjamin Kaduk src/afs/afs_fetchstore.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- OpenAFS Master Repository From gerrit@openafs.org Mon May 13 04:03:27 2024 From: gerrit@openafs.org (Gerrit Code Review) Date: Sun, 12 May 2024 23:03:27 -0400 Subject: OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_11-22-g195f154 Message-ID: <202405130303.44D33Rtc008331@openafs.MIT.EDU> The following commit has been merged in the openafs-stable-1_8_x branch: commit 195f154aaf2d8aff1f6debdb47c0db8f07cb5c5e Author: Cheyenne Wills Date: Thu Feb 29 17:53:31 2024 -0700 afs: Add static attribute to internal functions When building against a Linux 6.8 kernel, functions that are missing prototypes or declarations are flagged. We can add the static attribute to functions that are not referenced outside of the file that implements them to avoid having these functions flagged by the compiler. These functions are flagged due to missing prototypes when building against a Linux 6.8 kernel (which sets the -Wmissing-declarations and -Wmissing-prototypes compiler flags as default). Linux 6.8 commit: 'Makefile.extrawarn: turn on missing-prototypes globally' (0fcb70851f). When building against a kernel with CONFIG_WERROR=y, the build fails. There are no functional changes in this commit. Reviewed-on: https://gerrit.openafs.org/15625 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk (cherry picked from commit efee796f28b53bf3ffc03186f81790c36c23c94c) Change-Id: I0d923a65731f825d6c190056b0ccc3d362236706 Reviewed-on: https://gerrit.openafs.org/15700 Reviewed-by: Andrew Deason Reviewed-by: Michael Meffie Tested-by: Benjamin Kaduk Reviewed-by: Benjamin Kaduk src/afs/LINUX/osi_file.c | 2 +- src/afs/LINUX/osi_module.c | 4 ++-- src/afs/LINUX/osi_pag_module.c | 4 ++-- src/afs/afs_call.c | 6 +++--- src/afs/afs_disconnected.c | 20 ++++++++++---------- src/afs/afs_fetchstore.c | 42 +++++++++++++++++++++--------------------- src/afs/afs_icl.c | 4 ++-- src/afs/afs_pag_cred.c | 4 ++-- src/afs/afs_server.c | 2 +- src/afs/afs_vcache.c | 2 +- 10 files changed, 45 insertions(+), 45 deletions(-) -- OpenAFS Master Repository From gerrit@openafs.org Thu May 16 05:42:35 2024 From: gerrit@openafs.org (Gerrit Code Review) Date: Thu, 16 May 2024 00:42:35 -0400 Subject: OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_11-25-gfef1fc6 Message-ID: <202405160442.44G4gZ91040128@openafs.MIT.EDU> The following commit has been merged in the openafs-stable-1_8_x branch: commit fef1fc6f740c6f7395cf51ce99ed296652579c7d Author: Cheyenne Wills Date: Tue Mar 5 07:40:08 2024 -0700 rxgen: Declare generated PKG_OpCodeStats() The function {PKG}_OpCodeStats() is generated by rxgen, however a prototype for the function is not generated. The functions h_ProcMainBody_setup() and h_HeadofOldStyleProc_setup() in rpc_parse.c emit prototypes for {PKG}_ExecuteRequest() and {PKG}_TranslateOpCode(), but do not emit a prototype for {PKG}_OpCodeStats(). Update rxgen to emit a function prototype for {PKG}_OpCodeStats() in the generated header file. Use a variable to point to "PackagePrefix[PackageIndex]" in h_ProcMainBody_setup to improve readability. {PKG}_OpCodeStats(), specifically RXSTATS_OpCodeStats(), is flagged due to a missing prototype when building against a Linux 6.8 kernel (which sets the -Wmissing-declarations and -Wmissing-prototypes compiler flags as default). Linux 6.8 commit: 'Makefile.extrawarn: turn on missing-prototypes globally' (0fcb70851f). When building against a kernel with CONFIG_WERROR=y, the build fails. Reviewed-on: https://gerrit.openafs.org/15631 Tested-by: BuildBot Reviewed-by: Mark Vitale Reviewed-by: Benjamin Kaduk (cherry picked from commit 26bb4d143b31ba027cf2721ac731df67a174c43b) Change-Id: I9072d22d142b5b7a2f59b0cfc4026066ef1d9501 Reviewed-on: https://gerrit.openafs.org/15703 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Michael Meffie Reviewed-by: Benjamin Kaduk src/rxgen/rpc_parse.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) -- OpenAFS Master Repository From gerrit@openafs.org Thu May 16 17:31:29 2024 From: gerrit@openafs.org (Gerrit Code Review) Date: Thu, 16 May 2024 12:31:29 -0400 Subject: OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_11-28-g7b4802e Message-ID: <202405161631.44GGVT2o068013@openafs.MIT.EDU> The following commit has been merged in the openafs-stable-1_8_x branch: commit 7b4802efaf29ef76969c8b931a31e93dd4fbb000 Author: Cheyenne Wills Date: Mon Mar 11 09:05:33 2024 -0600 Linux 6.8: Use roken's strlcpy() in kernel module The Linux 6.8 commit 'string: Remove strlcpy()' (d26270061a) removed the the strlcpy function from the Linux kernel. The replacement function, strscpy(), cannot be used as a drop-in replacement as its currently a Linux kernel specific function and there are differences in the returned value. We can use roken's strlcpy() (provided in roken/strlcpy.c). Create a configure test to that defines its own strlcpy() to test if the kernel doesn't provide one itself. Note, we need to use a different function signature for strlcpy() from what the kernel might have otherwise the test build succeeds when the kernel does provide a strlcpy(). Update the OpenAFS kernel specific roken.h to define the prototype for strlcpy when it's not present in the Linux kernel. We need to match the defines used in the 'real' roken.h so the roken/strlcpy.c can build properly. Add defines for ROKEN_LIB_FUNCTION, ROKEN_LIB_CALL and ROKEN_LIB_VARIABLE to the kernel roken.h Update Linux's osi_machdep.h to include roken.h so the strlcpy protoype is available. Update the Linux MakefileProto to include the strcpy-kernel object when building the kernel module. Reviewed-on: https://gerrit.openafs.org/15646 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk (cherry picked from commit 30b18c165752e6d0ce7b6daa6a90453f5e5e6d17) Change-Id: I8013623e8f735d15bb7d4ac84ed0867f12b77783 Reviewed-on: https://gerrit.openafs.org/15706 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Michael Meffie Reviewed-by: Benjamin Kaduk src/afs/LINUX/osi_machdep.h | 1 + src/cf/linux-kernel-func.m4 | 11 +++++++++++ src/crypto/hcrypto/kernel/roken.h | 29 +++++++++++++++++++++++++++++ src/external/libafsdep | 1 + src/libafs/MakefileProto.LINUX.in | 6 ++++-- 5 files changed, 46 insertions(+), 2 deletions(-) -- OpenAFS Master Repository From gerrit@openafs.org Thu May 16 18:00:37 2024 From: gerrit@openafs.org (Gerrit Code Review) Date: Thu, 16 May 2024 13:00:37 -0400 Subject: OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_11-31-g4fc2754 Message-ID: <202405161700.44GH0b8u076146@openafs.MIT.EDU> The following commit has been merged in the openafs-stable-1_8_x branch: commit 4fc27548be88947ef58e2a3a3654a08ec6c334d9 Author: Michael Meffie Date: Tue Apr 9 10:57:26 2024 -0400 rxperf: Add -o option to rxperf client Add the -o (output) option to the rxperf client specify the output file. If not specified, the output is written to stdout, as before. Reviewed-on: https://gerrit.openafs.org/15731 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk (cherry picked from commit e6bc50524e1bde199f6643d9784fe331577bee90) Change-Id: I94a2f43c70f9cb5236c3ab4c5d2de66906eb68b3 Reviewed-on: https://gerrit.openafs.org/15735 Reviewed-by: Michael Meffie Reviewed-by: Andrew Deason Tested-by: Andrew Deason Reviewed-by: Benjamin Kaduk src/tools/rxperf/rxperf.c | 43 +++++++++++++++++++++++++++++++------------ 1 file changed, 31 insertions(+), 12 deletions(-) -- OpenAFS Master Repository