OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_11-25-gfef1fc6

Gerrit Code Review gerrit@openafs.org
Thu, 16 May 2024 00:42:35 -0400


The following commit has been merged in the openafs-stable-1_8_x branch:
commit fef1fc6f740c6f7395cf51ce99ed296652579c7d
Author: Cheyenne Wills <cwills@sinenomine.net>
Date:   Tue Mar 5 07:40:08 2024 -0700

    rxgen: Declare generated PKG_OpCodeStats()
    
    The function {PKG}_OpCodeStats() is generated by rxgen, however a
    prototype for the function is not generated.
    
    The functions h_ProcMainBody_setup() and h_HeadofOldStyleProc_setup()
    in rpc_parse.c emit prototypes for {PKG}_ExecuteRequest() and
    {PKG}_TranslateOpCode(), but do not emit a prototype for
    {PKG}_OpCodeStats().
    
    Update rxgen to emit a function prototype for {PKG}_OpCodeStats() in the
    generated header file.
    
    Use a variable to point to "PackagePrefix[PackageIndex]" in
    h_ProcMainBody_setup to improve readability.
    
    {PKG}_OpCodeStats(), specifically RXSTATS_OpCodeStats(), is flagged due
    to a missing prototype when building against a Linux 6.8 kernel (which
    sets the -Wmissing-declarations and -Wmissing-prototypes compiler flags
    as default). Linux 6.8 commit:  'Makefile.extrawarn: turn on
    missing-prototypes globally' (0fcb70851f). When building against a
    kernel with CONFIG_WERROR=y, the build fails.
    
    Reviewed-on: https://gerrit.openafs.org/15631
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    (cherry picked from commit 26bb4d143b31ba027cf2721ac731df67a174c43b)
    
    Change-Id: I9072d22d142b5b7a2f59b0cfc4026066ef1d9501
    Reviewed-on: https://gerrit.openafs.org/15703
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>

 src/rxgen/rpc_parse.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

-- 
OpenAFS Master Repository