[OpenAFS-devel] Mac OS 10.9 compile error

[Jason Edgecombe]

Hi everyone,

Thanks to Dave Botsch for setting up a new Mac OS 10.9 build slave. Dave 
requests that this build slave be added as a gerrit-triggered builder, 
but there are some compile problems blocking that. Please look into 
this. Thanks.

The build logs are at:
http://buildbot.openafs.org:8010/builders/macos10-9-x86_64-builder/builds/9/steps/compile/logs/stdio

http://buildbot.openafs.org:8010/builders/macos10-9-x86_64-builder

compile output:

/bin/sh ../../libtool --quiet --mode=compile --tag=CC gcc   -Os -Wall -Wstrict-prototypes -Wold-style-definition -Wpointer-arith -Wall -Wstrict-prototypes -Wold-style-definition -Werror -fdiagnostics-show-option -Wpointer-arith  -I/Users/buildbot/slave1/macos-10-9-x86_64-builder/build/src/config -I/Users/buildbot/slave1/macos-10-9-x86_64-builder/build/include -I. -I.    -arch i386 -arch x86_64  -D_REENTRANT -DAFS_PTHREAD_ENV  -o rbtree.lo -c rbtree.c
rbtree.c:425:14: error: variable 'child' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
     else if (node->right == NULL)
              ^~~~~~~~~~~~~~~~~~~
rbtree.c:428:5: note: uninitialized use occurs here
     child->parent = node->parent;
     ^~~~~
rbtree.c:425:10: note: remove the 'if' if its condition is always true
     else if (node->right == NULL)
          ^~~~~~~~~~~~~~~~~~~~~~~~
rbtree.c:353:34: note: initialize the variable 'child' to silence this warning
     struct opr_rbtree_node *child, *parent;
                                  ^
                                   = NULL
1 error generated.
make[3]: *** [rbtree.lo] Error 1
make[2]: *** [opr] Error 2
make[1]: *** [build] Error 2
make: *** [all] Error 2