[OpenAFS] 2005-01-17 snapshot: good so far on Fedora Core 2.6.10 kernels

chas williams - CONTRACTOR chas@cmf.nrl.navy.mil
Tue, 18 Jan 2005 16:22:48 -0500


In message <93F0C21DDF895CC819F04400@devrandom.blue.cert.org>,Jason McCormick w
rites:
>Great!  I'll have test packages for us done shortly.

i still manage to see a problem with 2.6 flushing dcache children (i have
a directory with lots of child entries).   it gets stuck walking d_alias.
the following seems to cure my problem.  i have been of the opinion that
d_prune_aliases() should be sufficient.  perhaps others using 2.6 could
try this patch and see if they get the dreaded "Increase -stat parameter
of afsd(VLRU cycle?)"

Index: src/afs/afs_vcache.c
===================================================================
RCS file: /cvs/openafs/src/afs/afs_vcache.c,v
retrieving revision 1.71
diff -u -u -r1.71 afs_vcache.c
--- src/afs/afs_vcache.c	16 Jan 2005 16:43:34 -0000	1.71
+++ src/afs/afs_vcache.c	18 Jan 2005 21:18:56 -0000
@@ -844,6 +844,7 @@
                 struct list_head *cur, *head = &(AFSTOI(tvc))->i_dentry;
                 AFS_FAST_HOLD(tvc);
                 AFS_GUNLOCK();
+#ifdef notdef
 shrink_restart:
                 DLOCK();
                 cur=head;
@@ -857,6 +858,7 @@
                     }
                 }
                 DUNLOCK();
+#endif
                 d_prune_aliases(AFSTOI(tvc));
                 AFS_GLOCK();
                 AFS_FAST_RELE(tvc);