[OpenAFS] Re: 1.4.14 salvager: salvage: invalid volume id specified; salvage aborted

[Kim Kimball]

Thanks.

I applied the patch(es) below [c39d0161552bf69affe839fcb36dfb858dbaedc1] 
to the 1.4.14 tree, which, judging from the number of rejects, wasn't 
the intent.

Was this done against 1.4.12?

In any case, not sure what I hosed manually going through the .rej 
files, but ended up with an unworkable solution -- salvage/exam/other 
funcs broken.

Have reverted to 1.4.14 original source and made a single change to 
declaration of vid in vol-salvage.c in src/vol, which gets salvager 
working.  Haven't yet applied Andrew's patch, but will.

I've got more time to fiddle with this.  Should I apply the 
c39d0161552bf69affe839fcb36dfb858dbaedc1 patch to 1.4.12 and report back 
with that as well?

Kim


On 3/11/2011 9:18 AM, Jeffrey Altman wrote:
> You will want Andrew's patch http://gerrit.openafs.org/#change,4199 to
> the salvager.
>
> On 3/11/2011 11:11 AM, Kim Kimball wrote:
>> Thanks much.
>>
>> I'll report back with results.
>>
>> Kim
>>
>>
>> On 3/10/2011 1:21 PM, Jeffrey Altman wrote:
>>> On 3/10/2011 2:49 PM, Kim Kimball wrote:
>>>> You're right.  Looking at the 1.4.14 source and comparing with what the
>>>> patches intended, it's clear the patch(es) never made it into the 1.4.14
>>>> release.
>>>>
>>>> There are patches here
>>>> http://web.mit.edu/jaltman/Public/OpenAFS/patches/vlserver-volid-1.patch
>>> that is not the final patch that was applied to master and is quite
>>> incomplete.   The full patchset to master is
>>>
>>>     SHA1: c39d0161552bf69affe839fcb36dfb858dbaedc1
>>>
>>> This was not applied to 1.4.
>>>
>>>
>> _______________________________________________
>> OpenAFS-info mailing list
>> OpenAFS-info@openafs.org
>> https://lists.openafs.org/mailman/listinfo/openafs-info
>>
>