[OpenAFS] Re: buildbot and packages

Andrew Deason adeason@sinenomine.net
Mon, 17 Sep 2012 17:18:16 -0500

On Mon, 17 Sep 2012 17:10:35 -0500
Ken Dreyer <ktdreyer@ktdreyer.com> wrote:

> > Isn't this what we already have? If you have a source tree that's
> > not exactly the commit for e.g. openafs-stable-1_6_1, you get a
> > string saying how many commits you are from a known point, and a git
> > hash. So, we should be able to identify exactly what build something
> > came from, with the existing versioning code, unless I'm mistaken
> > here.
> Ideally yes. The issue that I'm seeing is that the last tag on the
> openafs-stable-1_6_x branch was not 1.6.1 final; the
> openafs-stable-1_6_1 tag was placed on a child branch of the main
> 1_6_x branch. So I'm finding it hard to dig the value out with git
> describe.
> $ git checkout openafs-stable-1_6_x
> Switched to branch 'openafs-stable-1_6_x'
> $ ./build-tools/git-version .
> 1.6.1pre2-163-g4e480

Well, are you concerned with the packaging machine-readable version, or
what the user sees, or ...?

I don't think you can make that say something based on 1.6.1, since the
head of the 1.6.x branch right now is a different branch than 1.6.1. I
mean, if git-version said something like "this is 1.6.1 plus N patches",
that would be incorrect. Since, the head of 1.6.x is actually currently
"1.6.1pre2 plus N patches" (specifically 163, apparently), which is what
that says.

Andrew Deason