[AFS3-std] rpc refresh: FetchDirectory: discussion only
Matt W. Benjamin
matt@linuxbox.com
Thu, 10 Sep 2009 19:43:45 -0400 (EDT)
Hi Jeff,
I grok all this, and know almost enough to send a better draft later on.
* Ok, so lookup is tangential here, didn't mean to misquote you--when it is useful, is it RXAFS_Lookup as jaltman asked (and just a bitwise comparison)?
* Ok, back to split.
* Ok, let's have client read as much as it wants per call
Yes, I had intended NEntries to mean total entries. Ambiguous naming aside (and in spite it's being redundant if the client is reading piecewise), is that not useful information for it to have before it begins consuming the stream (though I guess that on re-reading rxgen's manpage, the parameter should have been marked INOUT so it goes in phase 1)?
Matt
----- "Jeffrey Hutzelman" <jhutz@cmu.edu> wrote:
> > proc FetchDirectory(
> > IN AFSFid *DirFid,
> > afs_uint32 Offset,
> > OUT afs_uint64 NEntries,
>
> I think you mean for this to be an IN parameter, indicating how many
> entries the client wants. You certainly don't need an OUT length,
> unless
> it's the _total_ number of entries in the directory. Vector types
> like
> AFSDirEntrySeq above include a count. However...
>
--
Matt Benjamin
The Linux Box
206 South Fifth Ave. Suite 150
Ann Arbor, MI 48104
http://linuxbox.com
tel. 734-761-4689
fax. 734-769-8938
cel. 734-216-5309