OpenAFS CVS Commit: openafs/src/viced by jaltman

Mon, 23 Jan 2006 16:30:18 EST

Update of /cvs/openafs/src/viced
In directory GRAND.CENTRAL.ORG:/home/jaltman/openafs/cvs-1-4/src/viced

Modified Files:
      Tag: openafs-stable-1_4_x
Log Message:
DELTA STABLE14-viced-grow-h_maxSlots-20060123


The size of h_maxSlots as computed based upon the value of
MAX_FILESERVER_THREAD is too small.   It is possible for h_lwpIndex
(in the pthread case) to have produce the same Slot value for multiple
threads.  In that case it is possible for the following to occur:

       X: h_Hold_r(host)
       X: H_UNLOCK
       E: H_LOCK
       E: Check h_Held_r(host); it is true, so don't hold
       E: H_UNLOCK
       X: H_LOCK
       X: h_Release_r(host)
       X: h_TossStuff_r(host)  [called by h_Release_r]
       X: H_UNLOCK
       E: CheckHost(host)

The end result would be a crash due to a reference to a null field
in the host processed by CheckHost.

This patch is a bit of a hack in that it solves the problem by increasing
the number of slots for threads and does not determine the correct number
of threads the process should be allowed to produce.

--- DELTA config for openafs-stable-1_4_x follows ---
STABLE14-viced-grow-h_maxSlots-20060123 openafs/src/viced/host.h