OpenAFS Master Repository branch, openafs-stable-1_4_x, updated. cf576939e903e989868145e599b6b8027a477b53

Gerrit Code Review
Tue, 1 Dec 2009 15:48:39 -0800 (PST)

The following commit has been merged in the openafs-stable-1_4_x branch:
commit cf576939e903e989868145e599b6b8027a477b53
Author: Andrew Deason <>
Date:   Mon Oct 26 14:09:41 2009 -0500

    Correct duplicate special inodes while salvaging
    Right now when the salvager encounters duplicate special inodes for a
    volume, it refuses to salvage the volume, presumably because it does not
    know which inodes to use when recreating the volume header.
    However, this can cause the confusing state where the fileserver and
    various volume utilities have no problem with a volume, but the salvager
    refuses to salvage it and marks the volume as needing salvage. When
    salvaging, if we already have a volume header, and we encounter
    duplicate special inodes, it is likely that the special inode referenced
    by the volume header is the correct one.
    So, instead of erroring out, keep track of which inodes are referenced
    in the volume header, and if there are any duplicates, either ignore or
    delete the unreferenced ones, depending on the -orphans setting. Also be
    a little more verbose when logging errors in this area.
    Tested-by: Andrew Deason <>
    Reviewed-by: Alistair Ferguson <>
    Reviewed-by: Steve Simmons <>
    Reviewed-by: Derrick Brashear <>
    (cherry picked from commit d393aabca577917b107afdd42efb40cc2fdac50c)
    Change-Id: I80f0666afe552354476bf0d5f85db8076854e974
    Tested-by: Andrew Deason <>
    Reviewed-by: Derrick Brashear <>

 src/vol/vol-salvage.c |  119 ++++++++++++++++++++++++++++++++++++++++++++++---
 1 files changed, 112 insertions(+), 7 deletions(-)

OpenAFS Master Repository