OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_66-89-g4057a99

Gerrit Code Review gerrit@openafs.org
Fri, 20 Nov 2009 06:52:11 -0800 (PST)


The following commit has been merged in the master branch:
commit 6f803428fdb1d85021cde1606498178d557a9db1
Author: Simon Wilkinson <sxw@inf.ed.ac.uk>
Date:   Wed Nov 18 20:07:04 2009 +0000

    Remove inode hinting for dcaches
    
    The VNOP read code has always contained incomplete support for inode
    hinting. In theory this would let us attach open cache files to dcache
    structures, so that we don't have the overhead of opening the file
    with every read that we do.
    
    However, this has been ifdef'd off ever since the first release, and
    is fundamentally broken - it relied upon structure elements that just
    don't exist, and has no mechanism for throttling the number of inode
    hints that are maintained. Inode hinting also required that we store
    an inode number within the osi_file structure (so hint validity could
    be checked), which causes a problem on some modern OS's.
    
    Simplify all of this, by just removing the partial hinting support.
    If we want to revisit this in the future, then the code is in git,
    but if we _do_ feel we want to keep open cache files around, it's
    probably better to start from scratch!
    
    Change-Id: Ia378922f7fcc24fb27b343015dbd16818302ec10
    Reviewed-on: http://gerrit.openafs.org/850
    Reviewed-by: Derrick Brashear <shadow@dementia.org>
    Tested-by: Derrick Brashear <shadow@dementia.org>

 src/afs/AIX/osi_file.c        |    1 -
 src/afs/DARWIN/osi_file.c     |    1 -
 src/afs/FBSD/osi_file.c       |    1 -
 src/afs/HPUX/osi_file.c       |    1 -
 src/afs/IRIX/osi_file.c       |    1 -
 src/afs/LINUX/osi_file.c      |    6 ++----
 src/afs/LINUX24/osi_file.c    |    7 ++-----
 src/afs/NBSD/osi_file.c       |    1 -
 src/afs/OBSD/osi_file.c       |    1 -
 src/afs/SOLARIS/osi_file.c    |    2 --
 src/afs/UKERNEL/afs_usrops.c  |    1 -
 src/afs/VNOPS/afs_vnop_read.c |   28 +---------------------------
 src/afs/afs_init.c            |    5 +----
 src/afs/afs_osi.h             |    1 -
 src/afs/afs_prototypes.h      |    3 ---
 15 files changed, 6 insertions(+), 54 deletions(-)

-- 
OpenAFS Master Repository