OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_65-8-g3e16433
Gerrit Code Review
gerrit@openafs.org
Sat, 3 Oct 2009 16:19:02 -0700 (PDT)
The following commit has been merged in the master branch:
commit 3e164335affa617137ebf280fe4c82a51c99894e
Author: Simon Wilkinson <sxw@inf.ed.ac.uk>
Date: Fri Oct 2 13:43:01 2009 +0100
Rationalise some #ifdefs in the LINUX osi layer
Introduce osi_compat.h, a place to hide compatibility #ifdefs. Make
a start on using this by purging #ifdefs from osi_vnodeops, and pushing
changes into inline compatibility functions.
The general idea here is to create a single location where we can do our
multiple version compatibility magic, and by doing so reduce the
complexity of the rest of the code. The approach is that where the
kernel introduces a new interface, we should switch to using it in the
rest of the code, and add a compatibility function (in osi_compat.h)
which implements the new interface in terms of the old one, suitably
protected by #ifdefs.
Where an interface changes signature, but not name, we should implement
an afs_<blah> version of the function which has the signature of the
newest version, and within that call out to the real kernel versions,
mapping between the different parameters as appropriate.
Reviewed-on: http://gerrit.openafs.org/568
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
src/afs/LINUX/osi_compat.h | 92 +++++++++++++++++++++++
src/afs/LINUX/osi_vfsops.c | 14 +--
src/afs/LINUX/osi_vnodeops.c | 166 +++++++++++++-----------------------------
3 files changed, 149 insertions(+), 123 deletions(-)
--
OpenAFS Master Repository