OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_65-36-gc8482d0
Gerrit Code Review
gerrit@openafs.org
Thu, 8 Oct 2009 08:00:35 -0700 (PDT)
The following commit has been merged in the master branch:
commit c8482d0fb97b3cfe0445c14a605af8c2d00fb50d
Author: Andrew Deason <adeason@sinenomine.net>
Date: Wed Oct 7 17:33:02 2009 -0500
Fix warnings in rxkad
Some miscellaneous warnings throughout rxkad:
rxkad/ticket5.c:
- Explicitly cast ticket blob to unsigned char*, as some functions take
a ticket as a char*, and some take it as an unsigned char*
- in tkt_DecodeTicket5, make 'start' and 'end' be unsigned, since that
is what their callers think they are
- Ignore implicit function declaration warnings (for CRC functons)
- Remove general warning inhibition
rxkad/ticket.c:
- in tkt_DecodeTicket, make 'start' and 'end' be unsigned, since that
is what their callers think they are
- Remove general warning inhibition
rxkad/v5der.c:
- In decode_enumerated, use der_get_unsigned instead of der_get_int,
since we're decoding an unsigned integer.
rxkad/rxkad_server.c:
- The last two arguments to rxkad_DeriveXORInfo are char*s, so
explicitly cast them to be so
- Remove general warning inhibition
rxkad/rxkad_common.c:
- rxkad_stats_t has had a couple of spares transform into
clientObjects/serverObjects; account for them and don't overrun the
spares array
Reviewed-on: http://gerrit.openafs.org/600
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
README.WARNINGS | 4 +---
src/rxkad/Makefile.in | 6 +++---
src/rxkad/rxkad_common.c | 4 ++--
src/rxkad/rxkad_prototypes.h | 8 ++++----
src/rxkad/rxkad_server.c | 2 +-
src/rxkad/ticket.c | 2 +-
src/rxkad/ticket5.c | 11 +++++++----
src/rxkad/v5der.c | 2 +-
8 files changed, 20 insertions(+), 19 deletions(-)
--
OpenAFS Master Repository