OpenAFS Master Repository branch, openafs-stable-1_4_x, updated. c9974c7a23a30fad44014238a87b15272ef90d99
Gerrit Code Review
gerrit@openafs.org
Wed, 28 Oct 2009 12:18:50 -0700 (PDT)
The following commit has been merged in the openafs-stable-1_4_x branch:
commit c9974c7a23a30fad44014238a87b15272ef90d99
Author: Andrew Deason <adeason@sinenomine.net>
Date: Thu Oct 22 11:12:30 2009 -0500
Avoid prematurely destroying callback_rxcon
Currently, h_GetHost_r and removeAddress_r can destroy the
callback_rxcon of a host. Having a NULL callback_rxcon can cause
segfaults in code that does not properly check if a host has been
HOSTDELETED before trying to use it.
Although such code is incorrect and should be fixed, we can still avoid
a segfault in those situations by not destroying callback_rxcon until we
destroy the host itself. This just prevents destroying callback_rxcon in
h_GetHost_r and removeAddress_r, leaving it to h_TossStuff_r to destroy
when it destroys the host.
Reviewed-on: http://gerrit.openafs.org/717
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit bbcfbe1a04eda9e75b1643be88cf9d4842a8aa86)
Change-Id: I4d44fca9b79b656bc70f8108616f23f2dfaa353f
Reviewed-on: http://gerrit.openafs.org/749
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
src/viced/host.c | 52 ++++++++++++++++++++++------------------------------
1 files changed, 22 insertions(+), 30 deletions(-)
--
OpenAFS Master Repository