OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_74-15-g54226e9
Gerrit Code Review
gerrit@openafs.org
Wed, 21 Apr 2010 16:09:28 -0700 (PDT)
The following commit has been merged in the master branch:
commit 54226e9ad45003f4f54b1a7ba2b13003dcf1edb7
Author: Russ Allbery <rra@stanford.edu>
Date: Mon Apr 19 22:01:27 2010 -0700
Fix UCONTEXT detection on ppc_linux26 via include order
param.linux26.h defines USE_UCONTEXT for all Linux platforms for
glibc 2.4 and higher, but it does this by testing __GLIBC__ and
__GLIBC_MINOR__. These are defined by features.h, which is included
by any system header. At least one system header must be included
before those are defined. lwp/process.c was including <afsconfig.h>
and <afs/param.h> before any other headers, leading to those macros
being undefined. Most of the Linux architectures either have their
own implementation or were explicitly defining USE_UCONTEXT in the
per-architecture param file, but ppc_linux26 was relying on the
default.
Fix this by reordering the includes to include the various system
headers before <afs/param.h> and add a comment explaining why.
This previously worked in earlier versions because the old
param.ppc_linux26.h file included <afs/afs_sysnames.h>, which
included "stds.h", which included a system header prior to the check
for ucontext. The new generic param file reverses that order.
Change-Id: I214e54f684afdef07e6e2dec5b6e6e4d255ab4ec
Reviewed-on: http://gerrit.openafs.org/1791
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
src/lwp/process.c | 14 ++++++++++----
1 files changed, 10 insertions(+), 4 deletions(-)
--
OpenAFS Master Repository