OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-devel-1_5_78-22-g0bddd65
Gerrit Code Review
Tue, 7 Dec 2010 16:04:39 -0800 (PST)
The following commit has been merged in the openafs-stable-1_6_x branch:
Author: Andrew Deason <firstname.lastname@example.org>
Date: Fri Nov 5 16:48:28 2010 -0500
vol: Do not give back not-checked-out vols
VAttachVolumeByName_r has logic to give back a volume over FSSYNC if
we checked out a volume but failed to attach it for whatever reason.
However, the logic used for determining if the volume was checked out
or not is a bit inaccurate (even moreso than the comments imply),
potentially causing us to VOL_ON volumes that don't exist at all.
Instead of trying to guess based on various conditions whether or not
we checked out the volume, keep track of a variable that is only set
when we actually checkout the volume from the fileserver. Then only
give back the volume if it is set.
Tested-by: Andrew Deason <email@example.com>
Reviewed-by: Derrick Brashear <firstname.lastname@example.org>
Tested-by: Derrick Brashear <email@example.com>
(cherry picked from commit e890f090e11d09b6e6b929642cbd92a56fb6e66e)
src/vol/volume.c | 48 +++++++++++++++++++++++++-----------------------
1 files changed, 25 insertions(+), 23 deletions(-)
OpenAFS Master Repository