OpenAFS Master Repository branch, master, updated. BP--openafs-stable-1_6_x-596-g8992210

Gerrit Code Review gerrit@openafs.org
Mon, 27 Dec 2010 12:22:45 -0800 (PST)


The following commit has been merged in the master branch:
commit 8992210f27671673a89a541776aa105238ad14cf
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sun Dec 26 14:54:43 2010 +0000

    Don't trust # of entries from ListAttributes
    
    ListAttributes returns the number of entries in its array as an RPC
    argument. But, we can't trust this, as it could be manipulated and
    end up pointing past the end of the returned array (which is counted,
    so the entries argument is actually pointless).
    
    Add bounds checking to the functions which use this value to prevent
    this problem.
    
    Change-Id: I62398d8f6b5c54318c1a42f1bad67a21c90ef944
    Reviewed-on: http://gerrit.openafs.org/3597
    Reviewed-by: Derrick Brashear <shadow@dementia.org>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>

 src/bucoord/commands.c      |    5 +++++
 src/libadmin/vos/vosutils.c |   11 +++++++++++
 src/volser/vsutils.c        |   43 ++++++++++++++++++++++++++++++++++++++++++-
 3 files changed, 58 insertions(+), 1 deletions(-)

-- 
OpenAFS Master Repository