OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_71-19-g8229e66

Gerrit Code Review gerrit@openafs.org
Wed, 3 Feb 2010 12:34:35 -0800 (PST)


The following commit has been merged in the master branch:
commit 8229e668deee3eb00a295a8c9ea96a66b7049687
Author: Simon Wilkinson <sxw@inf.ed.ac.uk>
Date:   Sat Nov 7 22:31:08 2009 +0000

    Add printf format checks to afs_com_err()
    
    Add gcc printf format checks to the afs_com_err() functions
    
    Deal with the fallout, in particular change callers which pass
    an empty format string to pass NULL instead - the com_err functions
    already permit this alternate use.
    
    There's a couple of real bugs here - in one case, we attempt to
    print a NULL pointer, rather than a security index, and in the other
    we supply a NULL format string, rather than the string we meant to
    print.
    
    Change-Id: Icd48f92a4447d4af3dba9a4caa2ff73c1657ad47
    Reviewed-on: http://gerrit.openafs.org/794
    Reviewed-by: Derrick Brashear <shadow@dementia.org>
    Tested-by: Derrick Brashear <shadow@dementia.org>

 src/aklog/klog.c         |   10 ++++----
 src/bucoord/commands.c   |   48 +++++++++++++++++++++++-----------------------
 src/bucoord/dump.c       |    2 +-
 src/bucoord/restore.c    |   18 ++++++++--------
 src/bucoord/ubik_db_if.c |    6 ++--
 src/comerr/com_err.h     |    8 +++++-
 src/kauth/admin_tools.c  |    2 +-
 src/ptserver/db_verify.c |    3 +-
 src/uss/uss_kauth.c      |    4 +-
 9 files changed, 53 insertions(+), 48 deletions(-)

-- 
OpenAFS Master Repository