OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_71-44-g4221d7a
Gerrit Code Review
gerrit@openafs.org
Mon, 8 Feb 2010 19:37:55 -0800 (PST)
The following commit has been merged in the master branch:
commit 4221d7acc8595a052dbc5fbb4366050c00d6ef37
Author: Antoine Verheijen <antoine@ualberta.ca>
Date: Mon Feb 8 16:01:46 2010 -0700
Fix segmentation fault in vsu_GetVolumeID
When determining the volume type of a volume, vsu_GetVolumeID() checks
to see if the volume name ends in '.backup' or '.readonly' by backing
up the appropriate number of characters from the end of the name. It
does not, however, check to see if it skips past the beginning of the
volume name. This can result in a segmentation fault (which it has for
me on many occasions during a vos release) depending on where memory
is allocated or how/if memory is protected.
This patch corrects this behaviour by checking the volume name string
length prior to doing the string comparison.
Change-Id: Ia27fcac76b86ae2707663caa6bff365a4e8dd0da
Reviewed-on: http://gerrit.openafs.org/1269
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
src/volser/vsutils.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
--
OpenAFS Master Repository