OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_72-42-g1e744d5

Gerrit Code Review gerrit@openafs.org
Mon, 22 Feb 2010 10:36:24 -0800 (PST)


The following commit has been merged in the master branch:
commit 1e744d5e56106093924869924fffde3a9093d140
Author: Andrew Deason <adeason@sinenomine.net>
Date:   Mon Feb 22 11:56:07 2010 -0600

    Prevent deadlock if fs_stateSave panics
    
    fs_stateSave can call ShutDownAndCore(PANIC) if it detects host list
    corruption. Right now this will deadlock the shutdown thread, since
    we're still holding a read lock on the FS state when we do so, and
    ShutDownAndCore will attempt to acquire a write lock. Do two things to
    make this a bit better:
    
     -- Unlock the FS state before calling fs_stateSave, sine we're no
     longer looking at the FS state (the 'state' in fs_stateSave refers to
     the host list and callback lists, not the state locked by
     FS_STATE_*LOCK)
    
     -- If ShutDownAndCore detects that it was called inside of
     ShutDownAndCore, skip shutting down the volume and host packages, since
     they have already been shut down
    
    Change-Id: I24a994ff85a6d866a5800b777c0cf5ab2ba466e4
    Reviewed-on: http://gerrit.openafs.org/1362
    Reviewed-by: Derrick Brashear <shadow@dementia.org>
    Tested-by: Derrick Brashear <shadow@dementia.org>

 src/viced/viced.c |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)

-- 
OpenAFS Master Repository