OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_68-86-g6789f17
Gerrit Code Review
Tue, 12 Jan 2010 23:05:45 -0800 (PST)
The following commit has been merged in the master branch:
Author: Jeffrey Altman <firstname.lastname@example.org>
Date: Mon Jan 11 14:21:11 2010 -0500
Windows: Protect buffers in smb_WriteData from simultaneous writes
smb_WriteData does not properly use CM_SCACHESYNC_WRITE to
protect buffers from simultaneous writes. Instead of simply
testing CM_SCACHESYNC_WRITE at the top of the while loop,
the flag must remain set until the entire write completes.
cm_SyncOp is now called once and cm_SyncOpDone is only called
upon final success or error.
In addition, as 'count' is unsigned, the test for count < 0
is replaced with count != 0.
Reviewed-by: Jeffrey Altman <email@example.com>
Tested-by: Jeffrey Altman <firstname.lastname@example.org>
src/WINNT/afsd/smb.c | 71 +++++++++++++++++++++++++++++++------------------
1 files changed, 45 insertions(+), 26 deletions(-)
OpenAFS Master Repository