OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_68-90-g1544243
Gerrit Code Review
gerrit@openafs.org
Thu, 14 Jan 2010 07:07:33 -0800 (PST)
The following commit has been merged in the master branch:
commit 1544243167b0f294f080866710b3f29dec133f02
Author: Andrew Deason <adeason@sinenomine.net>
Date: Mon Jan 11 13:36:32 2010 -0600
Always check VInitVolumePackage2 return code
Some programs were not checking the return code of VInitVolumePackage2.
Although some programs do not care so much if we fail to properly init
the volume package (SYNC debug tools), at the very least log/print an
error, so it doesn't silently fail.
Other programs are changed to exit when VInitVolumePackage2 fail, so
e.g. salvages don't accidentally cause corruption on 'logging'-mounted
UFS partitions.
In any case, ensure the return code is always checked anywhere it is
called.
Change-Id: I164d5920a5ea2dd7e5ed9ad4ccc578e9bdf0db0b
Reviewed-on: http://gerrit.openafs.org/1090
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
src/tsalvaged/salvsync-debug.c | 8 +++++++-
src/vol/fssync-debug.c | 8 +++++++-
src/vol/salvaged.c | 13 +++++++++++--
src/vol/salvager.c | 5 ++++-
src/vol/test/testpart.c | 5 ++++-
src/volser/vol-dump.c | 5 ++++-
src/volser/volmain.c | 5 ++++-
7 files changed, 41 insertions(+), 8 deletions(-)
--
OpenAFS Master Repository