OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_68-96-gd4f6ece
Gerrit Code Review
Thu, 14 Jan 2010 08:10:34 -0800 (PST)
The following commit has been merged in the master branch:
Author: Dan Hyde <email@example.com>
Date: Wed Jan 13 14:38:47 2010 -0500
volmonitor keep vtrans lock
VolMonitor must maintain the VTRANS lock the whole time it is walking
the allTrans list. Failure to do so can cause core dumps trying to
access memory that has already been free'd.
Two versions of this change were coded and tested. The other version
used the VTRANS lock only around a THOLD, but needed a TRELE, too.
Timing tests were run counting the number of vos status, vos listvol,
and vos backupsys operations that could be performed during a fixed
number of vos status operations. The THOLD/TRELE version caused other
vos operations to run about 5% slower.
Reviewed-by: Andrew Deason <firstname.lastname@example.org>
Reviewed-by: Derrick Brashear <email@example.com>
Tested-by: Derrick Brashear <firstname.lastname@example.org>
src/volser/volprocs.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
OpenAFS Master Repository