OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_68-106-g41ae68f
Gerrit Code Review
Sat, 16 Jan 2010 21:25:15 -0800 (PST)
The following commit has been merged in the master branch:
Author: Marc Dionne <email@example.com>
Date: Sat Jan 16 18:57:24 2010 -0500
uss: Fix IP address parsing and cleanup warnings
In uss_vol_GetServer(), the IP address octets are scanned into "char"
variables, and later cast to afs_int32 to build the address.
sscanf gives warnings because it's expecting an int pointer, and
testing shows that this code doesn't work as expected - the first
3 octets are always parsed as 0.
Use afs_int32 variables instead, which works, eliminates warnings and
simplifies the code.
Note that this code does not seem to be reachable currently.
It was probably meant to be used by planned additional uss commands.
Reviewed-by: Derrick Brashear <firstname.lastname@example.org>
Tested-by: Derrick Brashear <email@example.com>
src/uss/uss_vol.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
OpenAFS Master Repository