OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_74_1-237-g0efea8e
Gerrit Code Review
gerrit@openafs.org
Sat, 12 Jun 2010 22:37:17 -0700 (PDT)
The following commit has been merged in the master branch:
commit 0efea8e2b1162ef88ef27daeffa1acb69c850566
Author: Simon Wilkinson <sxw@inf.ed.ac.uk>
Date: Sun Jun 13 01:44:27 2010 +0100
bucoord: Use mkstemp properly
Use mkstemp wherever we have it available, to silence warnings
about mktemp's safety.
When we do use mkstemp, use it properly. It doesn't return void,
it returns an open filehandle. Convert this filehandle into a FILE *,
rather than throwing it away, and leaking an open file descriptor.
Caught by clang-analyzer
Change-Id: Ib5864f684c6d5a8686e0a872364a645c90a29390
Reviewed-on: http://gerrit.openafs.org/2144
Reviewed-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
src/bucoord/ubik_db_if.c | 16 ++++++++++++----
1 files changed, 12 insertions(+), 4 deletions(-)
--
OpenAFS Master Repository