OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_74_1-279-gf8981f1

Gerrit Code Review gerrit@openafs.org
Thu, 17 Jun 2010 20:06:53 -0700 (PDT)


The following commit has been merged in the master branch:
commit f8981f18dfdd5ae9efd03b9d247238dd83f46506
Author: Ben Kaduk <kaduk@mit.edu>
Date:   Thu Jun 17 00:27:51 2010 -0400

    Fix aklog segfault
    
    In auth_to_cell(), we only strdup() into the linkedcell argument
    if there is a linkedCell in the current cellconf.  However, in
    main(), we free linkedcell if it is non-NULL, but it is allocated
    on the stack and could contain garbage.  free() chokes on such
    garbage, causing aklog to abort().
    If we copy nothing into linkedcell, set it to NULL so that we
    do not attempt to free the bogus pointer.
    
    Change-Id: I92905a5f17021ce1bc41909f5ceb1b0344456d93
    Reviewed-on: http://gerrit.openafs.org/2213
    Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
    Reviewed-by: Russ Allbery <rra@stanford.edu>
    Tested-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Derrick Brashear <shadow@dementia.org>

 src/aklog/aklog.c |   14 +++++++++-----
 1 files changed, 9 insertions(+), 5 deletions(-)

-- 
OpenAFS Master Repository