OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_74_1-68-g1e69ec9

Gerrit Code Review
Tue, 4 May 2010 04:36:14 -0700 (PDT)

The following commit has been merged in the master branch:
commit 1e69ec9cfef0bc571d1b91432354f486d49480b5
Author: tharidufernando <>
Date:   Sat Apr 10 09:01:16 2010 +0530

    Windows: Secure C String usage in src\WINNT\afsd\fs.c
    The use of strlen, strcat, strcpy, strncpy and sprintf in
    src\WINNT\afsd\fs.c does not effectively protect against buffer
    overruns and string truncation errors.  This patchset replaces
    their use with StringCbLen, StringCbCat, StringCbCopy,
    StringCbCopyN, StringCbCopyEx and StringCbPrintf respectively from
    The functions sscanf, fscanf and scanf do not check for the size of
    the parameters so it is prone to buffer overruns. These functions
    can be replaced by sscanf_s, fscanf_s, scanf_s when the Visual Studio
    compiler version is 1400 or greater.  Also memcpy will be replaced
    by memcpy_s which will check for the size of the destination buffer.
    In all cases, failure conditions are handled.
    Patchset development was mentored by Asanka Herath and Jeffrey Altman.
    Change-Id: I01e9dfc616641c220b57d2871e3e140406df3653
    Tested-by: Jeffrey Altman <>
    Reviewed-by: Tharidu Fernando <>
    Tested-by: Tharidu Fernando <>
    Reviewed-by: Jeffrey Altman <>

 src/WINNT/afsd/fs.c |  826 ++++++++++++++++++++++++++++++++++++++++-----------
 1 files changed, 659 insertions(+), 167 deletions(-)

OpenAFS Master Repository