OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-devel-1_5_77-148-gab4e008

Gerrit Code Review
Wed, 3 Nov 2010 03:58:50 -0700 (PDT)

The following commit has been merged in the openafs-stable-1_6_x branch:
commit 2e595e929fc679bd5eb82084e0a60d23fe9e827f
Author: Ben Kaduk <>
Date:   Fri Oct 29 03:18:02 2010 -0400

    FBSD: correct and simplify vcache eviction routines
    osi_VM_FlushVCache and osi_TryEvictVCache were both attempting
    to be wrappers around vgone(), with some checks before hand.
    Implement the latter in terms of the former to prevent
    code duplication and propagation of incorrect code.
    Additionally, correct the locking around vgone().  The
    vnode lock must be held, and we must also increase the vnode's
    hold count so that it does not disappear out from under us.
    As we need the interlock to check the usecount, keep it
    locked until we lock the vnode lock, for extra protection.
    As an added bonus, we no longer try to call vgonel(), which
    is not an exported symbol and merely happened to work due
    to the current kernel linker implementation.
    Remove some stale comments.
    With this change, a parallel buildworld completes on
    my four-core machine.
    Reviewed-by: Derrick Brashear <>
    Tested-by: Derrick Brashear <>
    (cherry picked from commit aad83a30a82407bfa6ac15b49fd31d69b563e898)
    Change-Id: Ibf7f1744f0030c92b45b1558d7f5e52409208e60
    Tested-by: BuildBot <>

 src/afs/FBSD/osi_vcache.c |   48 +++++++++-----------------------------
 src/afs/FBSD/osi_vm.c     |   56 +++++++++++++++++++-------------------------
 2 files changed, 35 insertions(+), 69 deletions(-)

OpenAFS Master Repository