OpenAFS Master Repository branch, master, updated. BP--openafs-stable-1_6_x-452-g76de77c

Gerrit Code Review gerrit@openafs.org
Tue, 23 Nov 2010 04:51:13 -0800 (PST)


The following commit has been merged in the master branch:
commit 76de77c7f9a6f58e7d7e85554decaa2ac959db07
Author: Ben Kaduk <kaduk@mit.edu>
Date:   Sat Nov 6 00:02:31 2010 -0400

    FBSD: close race in afs_root
    
    Previously, we called afs_PutVCache(afs_globalVp) directly.  This
    is unsafe because PutVCache acquires locks which can sleep, losing
    the serialization of the GLOCK.  In rare circumstances, this can
    result in two threads simultaneously making that call, and the
    second one would panic in vputx() with a negative refcount.
    Close the race by using a local variable for the afs_PutVCache()
    calls, applying the change to afs_globalVp before dropping the GLOCK.
    While here, fix up other race conditions.
    
    Change-Id: Id62f27d4469a96c9becd9b031125bd6c910c3e9b
    Reviewed-on: http://gerrit.openafs.org/3275
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@dementia.org>

 src/afs/FBSD/osi_vfsops.c |   36 ++++++++++++++++++++++++------------
 1 files changed, 24 insertions(+), 12 deletions(-)

-- 
OpenAFS Master Repository