OpenAFS Master Repository branch, master, updated. BP--openafs-stable-1_6_x-256-ga91da7a
Gerrit Code Review
gerrit@openafs.org
Wed, 13 Oct 2010 21:04:04 -0700 (PDT)
The following commit has been merged in the master branch:
commit a91da7a7b91ce0c4584092cd666eca89d39b8abf
Author: Tom Keiser <tkeiser@sinenomine.net>
Date: Wed Oct 13 01:10:09 2010 -0400
don't release Volume lightweight ref too early
FSYNC_com_VolOff was releasing its lightweight ref before the error handling
code for VGetVolumeByVp_r was executed; this code needs to dereference the
Volume pointer for some of its logic. This was unsafe since
VCancelReservation_r() could have resulted in the Volume object being freed.
Move VCancelReservation_r() below the error handling block. NB: the error
handling block now relies upon the goto done/deny to cancel its lightweight
ref.
Change-Id: Ic920e45d55f7d1773585a5c0b004c722355b5725
Reviewed-on: http://gerrit.openafs.org/2968
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
src/vol/fssync-server.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
--
OpenAFS Master Repository