OpenAFS Master Repository branch, master, updated. BP--openafs-stable-1_6_x-293-gc8f4762

Gerrit Code Review
Sat, 23 Oct 2010 12:44:29 -0700 (PDT)

The following commit has been merged in the master branch:
commit c8f47626e2428449bfb64844e46fe5ad6b8e0f1c
Author: Jeffrey Altman <>
Date:   Thu Oct 21 14:23:18 2010 -0400

    Rx: Fix socket() handling so errors are properly detected
    socket() returns an osi_socket which on Windows is an
    unsigned type (HANDLE).  Therefore, tests of osi_socket < 0
    will never identify when the INVALID_SOCKET value is returned.
    On Windows, the OSI_NULLSOCKET is assigned to INVALID_SOCKET.
    Replace all comparisons of (osi_socket < 0) with
    (osi_socket == OSI_NULLSOCKET) as a means of detecting errors.
    In addition, do not pass socket() the protocol value 0 when
    IPPROTO_UDP is what is desired.
    Finally, perror() on Windows never reports any error from Winsock.
    perror() is a CRT function.  To get the real socket error
    WSAGetLastError() must be called and its value be written to
    Change-Id: Ibc392eeb733851f56dbc7398cb252a4753b95275
    Tested-by: BuildBot <>
    Reviewed-by: Jeffrey Altman <>
    Tested-by: Jeffrey Altman <>

 src/rx/rx_user.c      |   49 +++++++++++++++++++++++++++----------------------
 src/rxdebug/rxdebug.c |   14 +++++++++++++-
 2 files changed, 40 insertions(+), 23 deletions(-)

OpenAFS Master Repository