OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-devel-1_5_77-94-gbadfd71
Gerrit Code Review
gerrit@openafs.org
Mon, 25 Oct 2010 17:50:28 -0700 (PDT)
The following commit has been merged in the openafs-stable-1_6_x branch:
commit badfd710f7ae960a7b2e88b2cb80a2ef2aff4c8e
Author: Tom Keiser <tkeiser@sinenomine.net>
Date: Wed Oct 13 01:10:09 2010 -0400
don't release Volume lightweight ref too early
FSYNC_com_VolOff was releasing its lightweight ref before the error handling
code for VGetVolumeByVp_r was executed; this code needs to dereference the
Volume pointer for some of its logic. This was unsafe since
VCancelReservation_r() could have resulted in the Volume object being freed.
Move VCancelReservation_r() below the error handling block. NB: the error
handling block now relies upon the goto done/deny to cancel its lightweight
ref.
Reviewed-on: http://gerrit.openafs.org/2968
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit a91da7a7b91ce0c4584092cd666eca89d39b8abf)
Change-Id: Ie84351628fd112aa1724180a08dba10f0903a016
Reviewed-on: http://gerrit.openafs.org/3103
src/vol/fssync-server.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
--
OpenAFS Master Repository