OpenAFS Master Repository branch, master, updated. BP--openafs-stable-1_6_x-309-ge7066a9
Gerrit Code Review
gerrit@openafs.org
Tue, 26 Oct 2010 08:11:53 -0700 (PDT)
The following commit has been merged in the master branch:
commit e7066a9c30047e787d72f02dd1c28e5e473e494b
Author: Simon Wilkinson <sxw@your-file-system.com>
Date: Mon Oct 25 20:50:29 2010 +0100
rx: Fix starting of transmit timers
The code used to start the transmit timer once for every set of packets
that it sends. However, these packets might be sent individually or in
clumps, with blocking for sendmsg, and on peer->lock, between each set
of packet sends. This has the effect of, even on a very stable network,
producing a high degree of variation in RTTs and timeouts. This is a
particular issue where the connection size is larger, as the number of
packets being sent individually under the one timer grows too.
Fix this by moving timer initialisation to SendList. This already takes
the peer lock, so obtain the timeout value here too. This means that
each jumbo gram, or individual packet (where jumbograms are disabled)
is sent with its own start time, and stabilises RTTs.
Change-Id: Ifc8242211cedad9b52a66a44bbdee400130ab40b
Reviewed-on: http://gerrit.openafs.org/3137
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
src/rx/rx.c | 53 +++++++++++++++++++++--------------------------------
1 files changed, 21 insertions(+), 32 deletions(-)
--
OpenAFS Master Repository