OpenAFS Master Repository branch, master, updated. BP--openafs-stable-1_6_x-991-g12ea4a6
Gerrit Code Review
gerrit@openafs.org
Sat, 2 Apr 2011 12:41:00 -0700 (PDT)
The following commit has been merged in the master branch:
commit f5f0ce525a63264098cd0625769d642fe6f106ba
Author: Simon Wilkinson <sxw@your-file-system.com>
Date: Fri Apr 1 16:37:32 2011 +0100
Linux: Fix USE_UCONTEXT detection
On Linux, afs/param.h determines whether to use the ucontext()
function based on the glibc version. However, the glibc version
macros aren't available until a C library header has been included.
There have been a couple of attempts to fix this. The first included
afs_sysnames.h before the C library check, but this wasn't sufficient
to pull in a header for all builds. The second included stdio.h before
including afs/param.h in process.c.
Whilst the second approach works, it has the drawback that it breaks
our convention that afsconfig.h and afs/param.h must always be the first
includes in a file. More seriously, it means that the behaviour of
afs/param.h is different depending on where it appears in the include
order - which is especially dangerous for 3rd party user.
So, this patch tries to resolve all of this by explicitly including
features.h before doing the glibc version checks. The only danger I
can see here is that Linux platforms without glibc may lack a
features.h, but I suspect we have trouble building on such platforms
in any case.
Change-Id: Ief96d32b10372225335e2d2fbb7205da4bf5fc0a
Reviewed-on: http://gerrit.openafs.org/4389
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
src/config/param.linux24.h | 7 +++++--
src/config/param.linux26.h | 7 +++++--
src/lwp/process.c | 7 +------
3 files changed, 11 insertions(+), 10 deletions(-)
--
OpenAFS Master Repository