OpenAFS Master Repository branch, master, updated. BP--openafs-stable-1_6_x-1036-g0b510fe
Gerrit Code Review
Wed, 6 Apr 2011 08:17:28 -0700 (PDT)
The following commit has been merged in the master branch:
Author: Marc Dionne <email@example.com>
Date: Tue Apr 5 21:30:20 2011 -0400
ubik: don't rely on timeout value after select()
The value of timeout after a select() call should be considered
undefined; relying on its value is not portable.
Since IOMGR_Select doesn't modify the timeout it is given, the
intention of the code seems to be to wait for gradually increasing
timeout values, starting at 50ms. At least under Linux, the
timeout gets set to 0 by select() if it waited for the full specified
time, resulting in a much shorter maximum possible wait period.
Initialize the timeout value for each loop according to the existing
logic, to get consistent behaviour between the lwp and pthreaded code.
Tested-by: BuildBot <firstname.lastname@example.org>
Reviewed-by: Jeffrey Altman <email@example.com>
Reviewed-by: Derrick Brashear <firstname.lastname@example.org>
src/ubik/recovery.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
OpenAFS Master Repository