OpenAFS Master Repository branch, master, updated. BP--openafs-stable-1_6_x-1142-gaf175ce
Gerrit Code Review
gerrit@openafs.org
Thu, 28 Apr 2011 10:15:11 -0700 (PDT)
The following commit has been merged in the master branch:
commit af175ce2c7a4785ef1992d096adfdb27daa86ee4
Author: Andrew Deason <adeason@sinenomine.net>
Date: Wed Apr 27 14:23:43 2011 -0500
viced: Avoid ref leak on origin callback break
When breaking a callback, sometimes we send a callback to the host
that performed the callback-inducing operation. When we do this,
currently BreakCallBack gives the origin host structure to
MultiBreakCallBack_r, which avoids releasing that host after the
callback is broken.
However, BreakCallBack obtains a reference to every host to which it
delivers a callback, even if it is the origin host, so a reference is
leaked. Fix this by not ever passing a host to MultiBreakCallBack_r,
and just have MultiBreakCallBack_r release a reference for every host
to which it delivers a callback break.
FIXES 129376
Change-Id: I88503f29f80d4233c062ff448fc4d912e401e8e4
Reviewed-on: http://gerrit.openafs.org/4581
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
src/viced/callback.c | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)
--
OpenAFS Master Repository