OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-stable-1_6_0b-172-g2ad4d31

Gerrit Code Review gerrit@openafs.org
Thu, 8 Dec 2011 20:38:22 -0800 (PST)


The following commit has been merged in the openafs-stable-1_6_x branch:
commit 2ad4d31d40683e6e603b117043e154f0db97c3c8
Author: Ben Kaduk <kaduk@mit.edu>
Date:   Sun Nov 13 13:12:50 2011 -0500

    FBSD: cleanup dvp locking for ISDOTDOT
    
    This is a more correct version of
    c2ed2577f9c16df3088158fb593d7aab6e8690d0, which was reverted since
    it caused build issues on some versions and kernel panics on others.
    
    We do want to always unlock dvp before calling over the network
    in the ISDOTDOT case, but be sure to use the proper spelling
    for this operation (as the syntax has changed between FreeBSD versions).
    This requires not unlocking dvp right after the afs_lookup() call if
    it succeeds, letting us just lock the "child" vp (which is actually
    the parent starting from '/') first, and then re-lock dvp.
    
    The error case of afs_lookup() was already handled correctly in
    this logic, which is to say that it was incorrect before this change,
    attempting to recursively lock dvp which causes a panic.
    
    Reviewed-on: http://gerrit.openafs.org/6127
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@dementix.org>
    (cherry picked from commit 8e14168c9c77850ce0603d56f8aa280f73cb3114)
    
    Change-Id: I2d929875a9b008f0aa0b64bce7971932691d9956
    Reviewed-on: http://gerrit.openafs.org/6234
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>

 src/afs/FBSD/osi_vnodeops.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

-- 
OpenAFS Master Repository