OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-stable-1_6_0b-215-g0ea8851

Gerrit Code Review
Fri, 16 Dec 2011 03:03:34 -0800 (PST)

The following commit has been merged in the openafs-stable-1_6_x branch:
commit 5fb00398ef02bf453195a0bc50f5df95788557c7
Author: Simon Wilkinson <>
Date:   Tue May 31 08:28:51 2011 +0100

    vos: Don't leak/overflow bulkaddrs
    The vos listaddrs command repeatedly reuses a bulkaddrs array. It
    zeros it once (without freeing the allocated memory), and then
    repeatedly uses it without zeroing in a loop. This means that the XDR
    library assumes that a sufficiently large block is already allocated,
    doesn't reallocate for the incoming data, or check limits.
    This means that if the first call to VL_GetAddrsU returns a set of
    addresses smaller than subsequent calls, we'll write past the end
    of the array, causing memory corruption.
    Fix this by freeing the arrays correctly with each pass of the call.
    Reviewed-by: Jeffrey Altman <>
    Tested-by: BuildBot <>
    Reviewed-by: Derrick Brashear <>
    (cherry picked from commit b6add117ad210665a811213fe17a30fabbda3a3c)
    Change-Id: Ic3ae8f506e87d18fdc121ff21221f61c359e38aa
    Tested-by: Derrick Brashear <>
    Reviewed-by: Derrick Brashear <>

 src/volser/vos.c |   21 +++++++++++----------
 1 files changed, 11 insertions(+), 10 deletions(-)

OpenAFS Master Repository