OpenAFS Master Repository branch, master, updated. BP--openafs-stable-1_6_x-1447-gef28bc0
Gerrit Code Review
gerrit@openafs.org
Mon, 25 Jul 2011 13:38:58 -0700 (PDT)
The following commit has been merged in the master branch:
commit ef28bc08c18e750f6100535665d5258a317a0a2b
Author: Andrew Deason <adeason@sinenomine.net>
Date: Fri Jul 22 16:09:52 2011 -0500
libafs: Avoid duplicate afs_Analyze in bulk stat
In afs_DoBulkStat, we can call afs_Analyze multiple times for the same
set of connection objects. Since afs_Analyze puts its reference to the
given afs_conn and rx_connection structures, calling it more than once
can cause the reference counts on those objects to be lower than they
should be.
Instead of making another afs_Analyze call, just alter the error code
inside the normal do/while afs_Analyze loop, so the 'loop' afs_Analyze
call gets the appropriate error code from the first bulk stat'd entry.
Change-Id: Id6396f8e9d4757d54825d4915458bf8b5153984f
Reviewed-on: http://gerrit.openafs.org/5086
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
src/afs/VNOPS/afs_vnop_lookup.c | 33 +++++----------------------------
1 files changed, 5 insertions(+), 28 deletions(-)
--
OpenAFS Master Repository