OpenAFS Master Repository branch, openafs-stable-1_4_x, updated. openafs-stable-1_4_12-122-g0e5c743

[Gerrit Code Review]

The following commit has been merged in the openafs-stable-1_4_x branch:
commit 0e5c743b609c8d719c74eeefc7d7ecb0cf86a82d
Author: Simon Wilkinson <sxw@inf.ed.ac.uk>
Date:   Mon May 17 20:15:46 2010 +0100

    Fileserver: Don't sync every 10 seconds
    
    The patch which moved our calls to fsync into the background, added
    a sync prior to each batch of fsync calls. This is an incredibly bad
    idea.
    
    POSIX says that sync "shall cause all information in memory that
    updates file systems to be scheduled for writing out to all file
    systems". On Linux this means that we in effect perform an fsync()
    on every open filehandle on the entire system, and in addition flush
    all superblocks and journals out to disk. This makes the following
    fsync() calls superfluous - sync() will have already written out
    all of the data.
    
    Add to this the fact that the fileserver is doing this every 10
    seconds, and this becomes a major performance bottleneck,
    particularly if the machine uses a journalled fs - as any disk
    operations will end up blocking whilst the journal is written to
    disk.
    
    Reviewed-on: http://gerrit.openafs.org/1977
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Rainer Toebbicke <rtb@pclella.cern.ch>
    Tested-by: Derrick Brashear <shadow@dementia.org>
    Reviewed-by: Derrick Brashear <shadow@dementia.org>
    (cherry picked from commit 5ea24a7c5534b4fda7904284d21d34b6e52a3f27)
    
    Change-Id: Icdd0644d96d0c60ac02c7a6bb6c881bdaa15f939
    Reviewed-on: http://gerrit.openafs.org/4394
    Reviewed-by: Derrick Brashear <shadow@dementia.org>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>

 src/vol/ihandle.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

-- 
OpenAFS Master Repository