OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-stable-1_6_0pre6-8-gec0527e

Gerrit Code Review
Sun, 19 Jun 2011 20:48:23 -0700 (PDT)

The following commit has been merged in the openafs-stable-1_6_x branch:
commit ec0527e8ca664de233a711f92e998b94672b352a
Author: Ben Kaduk <>
Date:   Fri Jun 17 02:22:34 2011 -0400

    FBSD: do not FlushAllVCaches
    In normal operation, any AFS vcache with associated data will have
    an associated vnode, which will be on the list of vnodes associated
    with the /afs mountpoint.  We already call FreeBSD's vflush() in
    our afs_unmount, which walks the list of vnodes associated with the
    mountpoint and calls vgonel() on them, which calls VOP_CLOSE and
    VOP_RECLAIM on the vnode.  Our implementation of VOP_RECLAIM already
    calls FlushVCache, so in normal operation, FlushAllVCaches() will
    be a no-op.
    However, in the presence of bugs, it is actively harmful, causing
    panics.  For example, if a vnode has been reclaimed but FlushVCache
    failed (which we cannot report back since the VFS will panic in this
    case), and we attempt to flush it again, the associated vnode has
    already been cleaned up and we will panic.  Likewise if our list of
    vcaches becomes corrupt and has a vcache with bad or missing vnode
    for some other reason, we will panic.
    Since there is no gain in normal operation and abnormal operation
    is more likely to panic than save data, skip the extra flush.
    Tested-by: BuildBot <>
    Reviewed-by: Derrick Brashear <>
    (cherry picked from commit 03a54723eaf23b2aad0d026ba5f1a8e7343b3763)
    Change-Id: I866fb196f8368362bcd673ffb4908ab21a46c544
    Reviewed-by: Derrick Brashear <>
    Tested-by: Derrick Brashear <>

 src/afs/afs_call.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

OpenAFS Master Repository