OpenAFS Master Repository branch, master, updated. BP--openafs-stable-1_6_x-1300-gc0cfbc4

Gerrit Code Review
Mon, 20 Jun 2011 09:08:05 -0700 (PDT)

The following commit has been merged in the master branch:
commit c0cfbc40c8ef3de65f144560918cbd2a5bf187ec
Author: Simon Wilkinson <>
Date:   Fri Jun 17 19:12:09 2011 +0100

    rx: Make rx_softAckDelay & rx_lastAckDelay private
    The values of these two parameters directly affect the modifiers
    that are needed in the peer's RTT calculations, and so can not
    arbitrarily be changed by applications.
    lastAckDelay has been 400ms since the first OpenAFS release, and
    that value is used as a modifier when computing the timeout of the
    last packet. It is likely that any change which made this value
    longer than 400ms would have detrimental effects on deployed clients
    softAckDelay has been 100ms for a similar time period. We have
    chopped and changed the value of minPeerTimeout, so it is unclear
    what the maximal value for this parameter is. For much of OpenAFS's
    life, minPeerTimeout was a 350ms padding value, which suggests that
    copying TCP, and setting the maximal value at 200ms would be a safe
    option. For now, however, leave it at 100ms to avoid unexpected
    side effects.
    hardAckDelay is not addressed by this patch set, as all ACK packets
    sent from the application thread are marked as delayed, and so
    currently have no part in computing RTT times. It is likely, however,
    that any changes to the hard ACK timeout should be very carefully
    Change-Id: Ibdeae4577b09d120f22bb922697f92d63aaf0dff
    Reviewed-by: Derrick Brashear <>
    Tested-by: BuildBot <>

 src/rx/rx.c         |   23 +++++++++++++++++++----
 src/rx/rx_globals.h |    8 --------
 2 files changed, 19 insertions(+), 12 deletions(-)

OpenAFS Master Repository