OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-stable-1_6_0pre2-59-g511fc5d

Gerrit Code Review gerrit@openafs.org
Sat, 5 Mar 2011 05:53:44 -0800 (PST)


The following commit has been merged in the openafs-stable-1_6_x branch:
commit 511fc5d4b50bce273c16acef7b551b8517a6bf46
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sun Dec 26 14:54:43 2010 +0000

    Don't trust # of entries from ListAttributes
    
    ListAttributes returns the number of entries in its array as an RPC
    argument. But, we can't trust this, as it could be manipulated and
    end up pointing past the end of the returned array (which is counted,
    so the entries argument is actually pointless).
    
    Add bounds checking to the functions which use this value to prevent
    this problem.
    
    (cherry picked from commit 8992210f27671673a89a541776aa105238ad14cf)
    Reviewed-on: http://gerrit.openafs.org/3597
    Reviewed-by: Derrick Brashear <shadow@dementia.org>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    
    Change-Id: I318f2f956a48f10e91590ad9f28fab868d8ceb60
    Reviewed-on: http://gerrit.openafs.org/4134
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@dementia.org>

 src/bucoord/commands.c      |    5 +++++
 src/libadmin/vos/vosutils.c |   11 +++++++++++
 src/volser/vsutils.c        |   24 ++++++++++++++++++++++++
 3 files changed, 40 insertions(+), 0 deletions(-)

-- 
OpenAFS Master Repository