OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-stable-1_6_0pre4-30-gcfd5d14

Gerrit Code Review gerrit@openafs.org
Mon, 2 May 2011 19:19:25 -0700 (PDT)


The following commit has been merged in the openafs-stable-1_6_x branch:
commit cfd5d1461e6fa28ab277575991d5f8eda3e46ce0
Author: Andrew Deason <adeason@sinenomine.net>
Date:   Wed Apr 27 14:23:43 2011 -0500

    viced: Avoid ref leak on origin callback break
    
    When breaking a callback, sometimes we send a callback to the host
    that performed the callback-inducing operation. When we do this,
    currently BreakCallBack gives the origin host structure to
    MultiBreakCallBack_r, which avoids releasing that host after the
    callback is broken.
    
    However, BreakCallBack obtains a reference to every host to which it
    delivers a callback, even if it is the origin host, so a reference is
    leaked. Fix this by not ever passing a host to MultiBreakCallBack_r,
    and just have MultiBreakCallBack_r release a reference for every host
    to which it delivers a callback break.
    
    FIXES 129376
    
    Reviewed-on: http://gerrit.openafs.org/4581
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@dementia.org>
    (cherry picked from commit af175ce2c7a4785ef1992d096adfdb27daa86ee4)
    
    Change-Id: Ifd59c8ce93939f7b23e9f64bd7c0e527d3a2fa52
    Reviewed-on: http://gerrit.openafs.org/4592
    Reviewed-by: Derrick Brashear <shadow@dementia.org>
    Tested-by: Derrick Brashear <shadow@dementia.org>

 src/viced/callback.c |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)

-- 
OpenAFS Master Repository