OpenAFS Master Repository branch, openafs-devel-1_7_x, updated. openafs-devel-1_7_1-15-gb9caee7

Gerrit Code Review gerrit@openafs.org
Fri, 11 Nov 2011 10:15:08 -0800 (PST)


The following commit has been merged in the openafs-devel-1_7_x branch:
commit b9caee7cdf21588207f272b3eb79fb7370d95e07
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Wed Oct 12 09:47:14 2011 -0400

    rx: Don't clear the receive queue when out of packets
    
    We can end up discarding a receive queue that's been soft acked,
    effectively taking back soft acks we sent. Whilst the RX
    documentation says that a client can drop soft acked packets at
    will, our RX implementation assumes that if the final packet in
    a call has been soft acked, we won't clear the queue. If a client
    clears the queue in this situation, the call will hang.
    
    What *should* happen is that we should take necessary locks,
    confirm that we have not soft-acked all of the packets in a flow,
    and then discard, or, if we're just going to discard, error the
    call.
    
    Reviewed-on: http://gerrit.openafs.org/5603
    Reviewed-by: Derrick Brashear <shadow@dementix.org>
    Tested-by: Derrick Brashear <shadow@dementix.org>
    (cherry picked from commit f722a75fe21963d64217375f1f7bbb0eb14befb4)
    
    Change-Id: I2c3ffbc395a785794ec878be1d2feaebdf84b153
    Reviewed-on: http://gerrit.openafs.org/5845
    Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
    Tested-by: Jeffrey Altman <jaltman@secure-endpoints.com>

 src/rx/rx.c         |    5 +++--
 src/rx/rx_globals.h |    1 -
 2 files changed, 3 insertions(+), 3 deletions(-)

-- 
OpenAFS Master Repository