OpenAFS Master Repository branch, openafs-devel-1_7_x, updated. openafs-devel-1_7_1-72-g66730cd
Gerrit Code Review
gerrit@openafs.org
Sat, 12 Nov 2011 15:52:59 -0800 (PST)
The following commit has been merged in the openafs-devel-1_7_x branch:
commit a3297643410b3759362bb6798c345ba70b6f48f3
Author: Andrew Deason <adeason@sinenomine.net>
Date: Fri Aug 12 14:50:26 2011 -0500
LINUX: Revert group changes on keyring failure
On Linux kernels that support keyrings, when we setpag we try to add
the PAG to the session keyring and to the supplemental group list.
Currently, if we fail to add the PAG to the keyring (which may happen
due to key quotas, or possibly other reasons), we return failure but
the group list is still modified with the new PAG in it.
Therefore, if the keyring-based approach fails, the new PAG may still
be in use, but there are no keyring keys associated with that PAG, so
the PAG may never get destroyed. This can cause a large number of PAGs
to accumulate over time, causing performance problems.
So, change this so that, in the event that keyring installation fails,
we revert the group list back to what it was before we touched it.
Also mark all unixusers with the new PAG as expired, in case one got
created during processing. Thus, the new PAG never gets used.
Change-Id: I068158607d19e27db6dbeda84f912c52d4b1919f
Reviewed-on: http://gerrit.openafs.org/5238
Tested-by: Derrick Brashear <shadow@dementix.org>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
(cherry-picked from ee2fbffb04bb8b5098354646e262afa90c1b6f59)
Reviewed-on: http://gerrit.openafs.org/5901
Tested-by: Jeffrey Altman <jaltman@secure-endpoints.com>
Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
src/afs/LINUX/osi_groups.c | 41 ++++++++++++++++++++++++++++-----------
src/afs/LINUX/osi_prototypes.h | 2 +-
2 files changed, 30 insertions(+), 13 deletions(-)
--
OpenAFS Master Repository