OpenAFS Master Repository branch, openafs-devel-1_7_x, updated. openafs-devel-1_7_1-86-gcab590b
Gerrit Code Review
gerrit@openafs.org
Sat, 12 Nov 2011 15:55:40 -0800 (PST)
The following commit has been merged in the openafs-devel-1_7_x branch:
commit cab590b6a99374084da41bd4035164c0f5b09f5e
Author: Andrew Deason <adeason@sinenomine.net>
Date: Mon Oct 3 13:10:44 2011 -0500
viced: Check for HOSTDELETED in stillborn check
h_FindClient_r checks the connection rock for a client object twice.
First it sees if we already have a client object, and if we don't, we
effectively create one (or find a suitable one). Then we check again,
to see if someone else set the rock while we were creating a client
structure.
Currently, the first check checks if client->host->hostFlags has
HOSTDELETED set, but the second check does not. So, if the host
associated with the client has been deleted by someone else, currently
we will unnecessarily log a "stillborn client" message, and we will
continue to use the deleted host. If the host continues to be held by
someone, we will run into the same situation repeatedly on future
requests until all of the host references go away.
To fix this, also ignore HOSTDELETED clients when performing the
stillborn race check.
Change-Id: Ifbac6d7fafd42ca9fe47360ba3915c1b2b6908c2
Reviewed-on: http://gerrit.openafs.org/5614
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
(cherry-picked from b5a153fb75bb6642490e9856dc6212244a590301)
Reviewed-on: http://gerrit.openafs.org/5916
Tested-by: Jeffrey Altman <jaltman@secure-endpoints.com>
Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
src/viced/host.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
--
OpenAFS Master Repository