OpenAFS Master Repository branch, master, updated. BP--openafs-stable-1_6_x-1723-g5c6bd04
Gerrit Code Review
Fri, 30 Sep 2011 16:57:31 -0700 (PDT)
The following commit has been merged in the master branch:
Author: Andrew Deason <email@example.com>
Date: Thu Sep 29 14:49:53 2011 -0500
DAFS: Do not serialize state for invalid hosts
When we serialize host information for DAFS during shutdown, we have
no guarantee that the host is in a valid state when we look at it.
This can result in a host being saved to disk when we are waiting for
the host to respond to an RPC, and so the information about the host
is invalid. For example, we can save a host that has the
HWHO_INPROGRESS flag set, and when it is restored later, this can
cause odd behavior since the flag is set but no thread is actually
waiting for the host to respond.
So instead, during state serialization, try to determine if a host may
be in an invalid state, and simply skip the host if it may.
Tested-by: BuildBot <firstname.lastname@example.org>
Reviewed-by: Derrick Brashear <email@example.com>
src/tviced/serialize_state.c | 14 +++++++-------
src/viced/host.c | 41 +++++++++++++++++++++++++++++++++++++++++
2 files changed, 48 insertions(+), 7 deletions(-)
OpenAFS Master Repository