OpenAFS Master Repository branch, master, updated. BP--openafs-stable-1_6_x-1756-gf722a75
Gerrit Code Review
gerrit@openafs.org
Sun, 23 Oct 2011 15:37:47 -0700 (PDT)
The following commit has been merged in the master branch:
commit f722a75fe21963d64217375f1f7bbb0eb14befb4
Author: Simon Wilkinson <sxw@your-file-system.com>
Date: Wed Oct 12 09:47:14 2011 -0400
rx: Don't clear the receive queue when out of packets
We can end up discarding a receive queue that's been soft acked,
effectively taking back soft acks we sent. Whilst the RX
documentation says that a client can drop soft acked packets at
will, our RX implementation assumes that if the final packet in
a call has been soft acked, we won't clear the queue. If a client
clears the queue in this situation, the call will hang.
What *should* happen is that we should take necessary locks,
confirm that we have not soft-acked all of the packets in a flow,
and then discard, or, if we're just going to discard, error the
call.
Change-Id: Ic8e358b8648c1a6f0154009093468531a9e3cf74
Reviewed-on: http://gerrit.openafs.org/5603
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: Derrick Brashear <shadow@dementix.org>
src/rx/rx.c | 5 +++--
src/rx/rx_globals.h | 1 -
2 files changed, 3 insertions(+), 3 deletions(-)
--
OpenAFS Master Repository