OpenAFS Master Repository branch, master, updated. BP--openafs-stable-1_6_x-1690-g649d3a0
Gerrit Code Review
gerrit@openafs.org
Thu, 22 Sep 2011 06:34:29 -0700 (PDT)
The following commit has been merged in the master branch:
commit 649d3a0957eef0c607a63b47f11bd4a0ca8655ca
Author: Marc Dionne <marc.c.dionne@gmail.com>
Date: Wed Sep 21 20:31:33 2011 -0400
fs: fix setserverprefs where long is larger than afs_int32
Make the fscanf and scanf format specifiers match the type of the
target variable. This prevents trying to store a long int into an
afs_int32 variable which may be smaller, and overwriting neighbouring
data on the stack.
The effect on a 64-bit Linux system was that the high bits of "rank"
would overwrite the first 4 bytes of the scanned host name, causing
setserverprefs to fail with:
: couldn't resolve name.
Change-Id: I2100e7fe77a137257eb308ad127c151de84756bc
Reviewed-on: http://gerrit.openafs.org/5486
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: Derrick Brashear <shadow@dementix.org>
src/venus/fs.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
--
OpenAFS Master Repository