OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_76-2334-g5815c5f
Gerrit Code Review
gerrit@openafs.org
Sun, 8 Apr 2012 18:20:55 -0700 (PDT)
The following commit has been merged in the master branch:
commit de94f97649cbf36a5d8ae805a0d211573fcb11be
Author: Simon Wilkinson <sxw@your-file-system.com>
Date: Sat Mar 31 12:20:25 2012 -0400
auth: Make sure we get AF_INET addresses from DNS
The routines which do AFSDB and SRV lookups copy the results of
gethostbyname directly into an afs_int32, and use the size of the
result to limit the copy. If, for any reason, they get a result that
isn't an int, then they will overflow this value.
Check that the result we get from gethostbyname is in the INET
address family, and also limit the size of the copy by the size of the
destination, rather than that of the source.
Caught by clang-analyzer
Change-Id: Icf1426e090bc1ed382212d5de6c291d0816fb2c9
Reviewed-on: http://gerrit.openafs.org/7096
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
src/auth/cellconfig.c | 50 ++++++++++++++++++++++++++----------------------
1 files changed, 27 insertions(+), 23 deletions(-)
--
OpenAFS Master Repository